Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fixed version for winnow crate to fix new builds #2478

Merged
merged 1 commit into from
May 1, 2023

Conversation

acheroncrypto
Copy link
Collaborator

The latest release of Solana(1.14.17) comes with rustc 1.62.0-dev which causes issues with winnow crate's latest version(MSRV 1.64.0).

Any new build without a lock file that uses spl-token-2022 crate fails including CI.

This PR adds a temporary entry for anchor-spl that fixates winnow's version to 0.4.1(MSRV 1.60.0).

Also made this PR for v.14 branch on Solana repo to use the latest version of platform-tools(rustc 1.68.0) solana-labs/solana#31418

@vercel
Copy link

vercel bot commented May 1, 2023

@acheroncrypto is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@acheroncrypto acheroncrypto merged commit a195106 into coral-xyz:master May 1, 2023
Aursen added a commit to Aursen/anchor that referenced this pull request May 5, 2023
commit ac86e15
Author: Matthew Callens <[email protected]>
Date:   Wed May 3 17:53:46 2023 -0500

    spl: remove mpl `create_metadata_account_v2` wrapper that were removed from program (coral-xyz#2480)

    * remove mpl ix wrappers that were removed from program

    * update changelog

commit c166712
Author: acheron <[email protected]>
Date:   Wed May 3 09:09:41 2023 +0200

    bench: Add a script to sync benchmark results for all versions (coral-xyz#2477)

commit a195106
Author: acheron <[email protected]>
Date:   Mon May 1 13:39:50 2023 +0200

    spl: Use fixed version for `winnow` crate to fix new builds (coral-xyz#2478)

commit 03b1e4d
Author: acheron <[email protected]>
Date:   Thu Apr 27 12:10:23 2023 +0200

    Upgrade `clap` to 4.2.4 (coral-xyz#2474)

commit 876ef41
Author: Proph3t <[email protected]>
Date:   Thu Apr 27 08:53:04 2023 +0000

    docs: fix broken links in `AccountLoader` docs (coral-xyz#2473)

commit c14ae6b
Author: Tuan Pham Minh <[email protected]>
Date:   Wed Apr 26 00:07:39 2023 +0700

    Fix typo of `is_signer` field in intro-to-solana docs page (coral-xyz#2469)
@acheroncrypto acheroncrypto added dependencies Pull requests that update a dependency file and removed ci labels May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file spl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant